-
Notifications
You must be signed in to change notification settings - Fork 879
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make status
of Task a readonly field
#4552
Conversation
🦋 Changeset detectedLatest commit: 6eea566 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
📊 Tachometer Benchmark ResultsSummarynop-update
render
update
update-reflect
Resultsthis-change
render
update
update-reflect
this-change, tip-of-tree, previous-release
render
update
nop-update
this-change, tip-of-tree, previous-release
render
update
this-change, tip-of-tree, previous-release
render
update
update-reflect
|
3d45360
to
8739cf1
Compare
This seems good to me. I think that we can consider We'll need the changeset file. Run |
The size of lit-html.js and lit-core.min.js are as expected. |
ping @jrencz - can you add a changeset file? |
It's there: .changeset/smart-pianos-kick.md Or is there something else I need to do? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! LGTM
Fix #4550
I'm not sure whether to makr it as BC break (major) or just as a patch - I see potential for this change to affect some implementations even if field was used against its intended purpose